New Add-on: Ability not ready/You are busy Spam Removal

[ciuine]

Made the add-on fully capable of function by readdressing the code structure and all that. It will no longer kill the Warnings add-on without restarting it.

To address Ruffian's idea, it's possible but would require notification upon completion of the spell, which I attempted in one of my recent tests but the argument wouldn't pass. So... Not doable with what I have tested; it's quite possible that Event_Action_Progress_Finished does work in some way though. Just not with what I've tested it for. If possible a simple x++ type switch which results in x restarting on Progress Finished would turn on and off the switch to turn on and off the Warning add-on.

[ptd165]

Still doesn't work. I still get the spam.

[ciuine]

Maybe you can clue me in on the "Still" part of your post, as well as tell me why it doesn't work for you. Because I just logged on and tested it and it did exactly what it was supposed to.

[ptd165]

Well, there's not that much to explain. I copy the thing to the addons folder and it does nothing in-game. Maybe re-installing or some sh-it like that will work.

[ciuine]

What do the folders look like? It should just be NNRS then inside two .XDB's and one .LUA.

This add-on has no "visible" function other than killing the Ability not ready/You are busy spam attached to skills while standing still; an "invisible" function.

It works fine for me and I've never modified my end of this add-on after uploading it.

[guzaorc]

It works great with me, I dont see Abillity not ready yet or stuff like that.

[ciuine]

Thanks for the confirmation, Tihi.

[guzaorc]

Can you add a filter for when the target is far away spam?

[ciuine]

Copy and paste this, Tihi.

Code: Select all

-------------------------------------------------------------------------------
-- FUNCTION
-------------------------------------------------------------------------------

function OnEventSpellFinished()
    common.StateLoadManagedAddon( "Warnings" )
end

function OnEventSpellFailed( params )
    if params.sysId == "ENUM_ActionFailCause_Occupied" or params.sysId == "ENUM_ActionFailCause_Cooldown" or params.sysId == "ENUM_ActionFailCause_TooFar" then
        common.StateUnloadManagedAddon( "Warnings" )
        local x = 1
        if x == 1 then
            OnEventSpellFinished()
        end
    end
end

--------------------------------------------------------------------------------
-- INITIALIZATION
--------------------------------------------------------------------------------
function Init()
    common.RegisterEventHandler( OnEventSpellFailed, "EVENT_ACTION_FAILED_SPELL" )
end
--------------------------------------------------------------------------------
Init()
--------------------------------------------------------------------------------

For future reference, here are most of the reasons the warnings mod activates negatively;

Code: Select all

"ENUM_ActionFailCause_NoFail"
"ENUM_ActionFailCause_Void"
"ENUM_ActionFailCause_Cooldown"
"ENUM_ActionFailCause_Disabled"
"ENUM_ActionFailCause_TooFar"
"ENUM_ActionFailCause_NotInGroup"
"ENUM_ActionFailCause_Immune"
"ENUM_ActionFailCause_NotInFront"
"ENUM_ActionFailCause_NoLoS"
"ENUM_ActionFailCause_NoPath"
"ENUM_ActionFailCause_NoTarget"
"ENUM_ActionFailCause_NoTargetPoint"
"ENUM_ActionFailCause_Occupied"
"ENUM_ActionFailCause_Resisted"
"ENUM_ActionFailCause_NotFriend"
"ENUM_ActionFailCause_NotEnemy"
"ENUM_ActionFailCause_BarrierInNotActive"
"ENUM_ActionFailCause_CannotTakeItem"
"ENUM_ActionFailCause_WrongCharacterClass"
"ENUM_ActionFailCause_ItemCountTooSmall"
"ENUM_ActionFailCause_ItemCountTooBig"
"ENUM_ActionFailCause_WrongCreatureRace"
"ENUM_ActionFailCause_NotEquipped"
"ENUM_ActionFailCause_NoItem"
"ENUM_ActionFailCause_NotInScriptZone"
"ENUM_ActionFailCause_NotManaCaster"
"ENUM_ActionFailCause_NotEnergyUser"
"ENUM_ActionFailCause_NotHonorUser"
"ENUM_ActionFailCause_WrongMobWorld"
"ENUM_ActionFailCause_NotInCombat"
"ENUM_ActionFailCause_InCombat"
"ENUM_ActionFailCause_CannotStrike"
"ENUM_ActionFailCause_TooClose"
"ENUM_ActionFailCause_NoShield"
"ENUM_ActionFailCause_NoMainhandWeapon"
"ENUM_ActionFailCause_NotEnoughMana"
"ENUM_ActionFailCause_NotEnoughEnergy"
"ENUM_ActionFailCause_NotEnoughHonor"
"ENUM_ActionFailCause_NoBuff"
"ENUM_ActionFailCause_NotEnoughDefenceComboPoints"
"ENUM_ActionFailCause_NotEnoughOffenceComboPoints"
"ENUM_ActionFailCause_InterruptedMove"
"ENUM_ActionFailCause_Canceled"
"ENUM_ActionFailCause_Fizzled"
"ENUM_ActionFailCause_Evaded"
"ENUM_ActionFailCause_QuestNotActive"
"ENUM_ActionFailCause_CreatureLevelTooSmall"
"ENUM_ActionFailCause_QuestNotFinished"
"ENUM_ActionFailCause_NotNeededForQuests"
"ENUM_ActionFailCause_QuestAlreadyVisitedScriptZone"
"ENUM_ActionFailCause_QuestActive"
"ENUM_ActionFailCause_WrongFaction"
"ENUM_ActionFailCause_InterruptedDamage"
"ENUM_ActionFailCause_InterruptedChangeTarget"
"ENUM_ActionFailCause_HealthNotLower"
"ENUM_ActionFailCause_HealthNotHigher"
"ENUM_ActionFailCause_LootableOccupied"
"ENUM_ActionFailCause_Dead"
"ENUM_ActionFailCause_MorePowerfulEffectActive"
"ENUM_ActionFailCause_HavePet"
"ENUM_ActionFailCause_DontHavePet"
"ENUM_ActionFailCause_NotPvpAllFlag"
"ENUM_ActionFailCause_NotPvpFactionFlag"
"ENUM_ActionFailCause_NotPvpNoneFlag"
"ENUM_ActionFailCause_NotEnoughSkillScore"
"ENUM_ActionFailCause_NotAvatar"
"ENUM_ActionFailCause_NotDead"
"ENUM_ActionFailCause_ResurrectNotActive"
"ENUM_ActionFailCause_ExploitForQuestsOnly"
"ENUM_ActionFailCause_CannotBeResized"
"ENUM_ActionFailCause_QuestCounterLessThenTest"
"ENUM_ActionFailCause_QuestStatusMismatch"
"ENUM_ActionFailCause_CannotAttack"
"ENUM_ActionFailCause_CartridgeBeltIsEmpty"
"ENUM_ActionFailCause_NoCartridgeBelt"
"ENUM_ActionFailCause_NoPsionicContact"
"ENUM_ActionFailCause_StatTooLow"
"ENUM_ActionFailCause_DeviceAlreadyInUse"
"ENUM_ActionFailCause_CreatureIsTooFat"
"ENUM_ActionFailCause_DeviceBroken"
"ENUM_ActionFailCause_DeviceOffline"
"ENUM_ActionFailCause_TargetNotVisible"
"ENUM_ActionFailCause_NotEnoughCombatAdvantage"
"ENUM_ActionFailCause_BuffStackCountNotInRange"


Just slap on an "or params.sysId == " in front of any of those and it'll turn off the Warnings add-on for that error.

[orbister]

You know, I'm still trying to figure out a situation where this would be useful (this is no dig on drind, more I am trying to understand why anyone would -want- this sort of thing to begin with.)

Why would you ever -not- want to know that an ability didn't go off as planned?

Maybe it is a factor of how I play MMOs, I tend to get into rotations (i.e. hit 1-1-1-3-1-1-4, repeat until mob dies) and most rotations very much care about previous abilities going of as planned (see: pallies, marks of the pariah, and retribution.) I just am not sure why you would want to be flying blind about some attack/spell not even being executed because it was on cooldown or such.

Can anyone who wants this sort of add-on enlighten me? I've actually got something a bit more fleshed out along these lines in the works, but this "what good is it?" question keeps nagging me.

even though it's been pretty much answered this is my take on this question, i play a warrior, sometimes people run away from me with very little HP so if my charge is still in cooldown i spam my ranged weapon skill to finish him/her off, sometimes i just spam charge if the running person has more hp that i could take with my crossbow. and the BILLIONS of "not ready" messages hurt my pretty eyes